Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy PR : testing docker container options in GATK Spark modules #1430

Merged
2 commits merged into from
Mar 8, 2024
Merged

Dummy PR : testing docker container options in GATK Spark modules #1430

2 commits merged into from
Mar 8, 2024

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Mar 4, 2024 •
edited
Loading

Testing docker container options in GATK Spark modules. - Just a dummy PR for discussion and triggering CI-tests.

In this PR, I made changes to the modules (like Jonas did). However, I would prefer a solution where we don't change the modules but just alter the containerOptions in the corresponding config.

If we're to update the modules, then I guess they should first be updated in the modules-repo? (Or are we perhaps going to make a "local" patch of the Spark modules?)

Note that the following (silly) test of joint-germline with profile use_gatk_spark also work on this PR:

NXF_VER=24.01.0-edge PROFILE=docker nextflow run main.nf -profile test_cache,targeted,use_gatk_spark --input ./tests/csv/3.0/mapped_joint_bam.csv --tools haplotypecaller --step variant_calling --joint_germline --outdir results --known_snps_vqsr false --known_indels_vqsr false

(The test is "silly" because it doesn't actually call any Spark modules.)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ea92fd7

+| ✅ 181 tests passed       |+
#| ❔  14 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowSarek.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowSarek.groovy
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/sarek/sarek/.github/workflows/awstest.yml
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-04 22:11:22

@asp8200 asp8200 mentioned this pull request Mar 7, 2024
Merged
@asp8200 asp8200 closed this pull request by merging all changes into nf-core:dev in 2e06e65 Mar 8, 2024
@asp8200
Copy link
Contributor Author

asp8200 commented Mar 21, 2024

@maxulysse : This solution also works with awsbatch and Spark.

@asp8200 asp8200 deleted the fix_docker_runoptions branch June 4, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen FriederikeHanssen will be requested when the pull request is marked ready for review FriederikeHanssen is a code owner

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse will be requested when the pull request is marked ready for review maxulysse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asp8200